Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): better titles and correct breadcrumbs #620

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Aug 2, 2024

Improves the titles of generated pages.
ie: Body.json - Fetch - Web documentation.
In docs.deno.com we will parse it out and strip out the documentation part and replace it with - Deno Docs.

Also fixes breadcrumbs of drilldown properties/methods not containing the category.
Changes also the test infrastructure to correspond to a more realistic scenario.

@crowlKats crowlKats changed the title fix(html): better titles fix(html): better titles and correct breadcrumbs Aug 2, 2024
Comment on lines -16 to -19
<script src="..&#x2F;..&#x2F;search_index.js" defer></script>
<script src="..&#x2F;..&#x2F;script.js" defer></script>
<script src="..&#x2F;..&#x2F;fuse.js" defer></script>
<script src="..&#x2F;..&#x2F;search.js" defer></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes actually expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, related to

Changes also the test infrastructure to correspond to a more realistic scenario.

@crowlKats crowlKats merged commit 4123592 into main Aug 5, 2024
5 checks passed
@crowlKats crowlKats deleted the better-titles branch August 5, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants