chore: remove core.metrics()
#896
Conversation
core/ops_metrics.rs
Outdated
| @@ -116,76 +113,3 @@ impl OpMetricsSummary { | |||
| self.ops_dispatched_async > self.ops_completed_async | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Default, Debug)] | |||
| pub struct OpMetricsSummaryTracker { | |||
There was a problem hiding this comment.
IIUC, core.metrics() was the only symbol that used this struct.
There was a problem hiding this comment.
I believe this is actually used by the deno test for leaking ops discovery. This should most likely stay. See runtime/worker.rs in Deno repo.
|
I've filed a PR for the failing builds in deno_core. #895 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
+ Coverage 81.43% 81.67% +0.23%
==========================================
Files 97 98 +1
Lines 23877 24668 +791
==========================================
+ Hits 19445 20147 +702
- Misses 4432 4521 +89 ☔ View full report in Codecov by Sentry. |
core/ops_metrics.rs
Outdated
| @@ -116,76 +113,3 @@ impl OpMetricsSummary { | |||
| self.ops_dispatched_async > self.ops_completed_async | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Default, Debug)] | |||
| pub struct OpMetricsSummaryTracker { | |||
There was a problem hiding this comment.
I believe this is actually used by the deno test for leaking ops discovery. This should most likely stay. See runtime/worker.rs in Deno repo.
|
Please merge, @bartlomieju |
As
Deno.metrics()is now removed from the runtime. Disclaimer: I'm not very familiar with this codebase. I'm not sure if there are other things that could be cleaned up.