Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Workspace to WorkspaceContext? #93

Closed
dsherret opened this issue Jul 18, 2024 · 0 comments · Fixed by #94
Closed

Rename Workspace to WorkspaceContext? #93

dsherret opened this issue Jul 18, 2024 · 0 comments · Fixed by #94

Comments

@dsherret
Copy link
Member

Because it has information about the start directory. This will make it less confusing in the LSP.
@dsherret dsherret changed the title Rename Workspace to WorkspaceContext Rename Workspace to WorkspaceContext? Jul 18, 2024
This was referenced Jul 18, 2024
Merged
Merged
dsherret added a commit that referenced this issue Jul 18, 2024
@dsherret
refactor: separate WorkspaceContext and Workspace (#94)
a953fca 
After this PR, I'll add a `Workspace` cache similar to the deno_json and
package.json, which will help out in the LSP.

Closes #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: separate WorkspaceContext and Workspace dsherret/deno_config
1 participant
@dsherret