-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch post loading to async #116
Conversation
blog.tsx
Outdated
// Switch to async to speed larger blogs | ||
// await loadPost(postsDirectory, entry.path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i understand this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. It didn't make sense of the context of the other stub comment above it, so I removed them both since the change resolves the stub and the additional comment brought no new meaning.
This PR should significantly improve server cold start. Can someone from the core team merge this? |
They need to sign contracts with people who have more time to maintain more puppet projects, or just hand them over to suitable people. |
I'm concerned about the case where the number of posts are very large. Can you use pooledMap from std to limit the number of the concurrent file requests? |
Does this look more appropriate? What is the largest poolLimit value that makes sense? I started with 10 but that was still pretty slow for my use case so I upped it to 25... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
For issue #87