feat: language agnostic rust codegen #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliassjogreen
changed the title
|
@eliassjogreen maybe the new CLI should be a custom cargo subcommand? https://github.com/rust-lang/cargo/wiki/Third-party-cargo-subcommands |
|
@littledivy Yep I agree, that sounds like a wise choice |
littledivy
reviewed
Jan 24, 2022
test.ts
Outdated
Comment on lines
110
to
118
| (__source instanceof ArrayBuffer | ||
| ? __source | ||
| : __source instanceof Uint8Array | ||
| ? __source.buffer | ||
| : __source instanceof Deno.UnsafePointer | ||
| ? new Deno.UnsafePointerView(__source).getArrayBuffer(24) | ||
| : __source instanceof Deno.UnsafePointerView | ||
| ? __source.getArrayBuffer(24) | ||
| : undefined)!; |
There was a problem hiding this comment.
This can be a helper function.
|
Closing because stale and merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #43, #4, #23 by implementing a new codegen in rust which in turn will be used by the macro and in the future extensions to deno bindgen which could enable for example c header support.
Todo:
codegencratecodegen)Previous works, references and resources: