Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ptr and struct type output + async support (close #40) #41

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Add ptr and struct type output + async support (close #40) #41

merged 2 commits into from
Jan 10, 2022

Conversation

zifeo
Copy link
Contributor

@zifeo zifeo commented Jan 10, 2022

This is my first contrib in rust, please have a deep look.

@littledivy
Copy link
Member

Amazing work! Thanks @zifeo

@littledivy littledivy linked an issue Jan 10, 2022 that may be closed by this pull request
High level support for returning struct #40
Closed
littledivy
littledivy approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deno_bindgen_macro/src/lib.rs Outdated Show resolved Hide resolved
@littledivy littledivy merged commit ccbd96e into denoland:main Jan 10, 2022
@zifeo zifeo deleted the f-40 branch January 10, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High level support for returning struct
2 participants
@zifeo @littledivy