Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot fetch darwin arm64 binary #125

Merged
merged 2 commits into from
Jun 5, 2023
Merged

fix: cannot fetch darwin arm64 binary #125

merged 2 commits into from
Jun 5, 2023

Conversation

skanehira
Copy link
Contributor

Fixed incompatibility with M1 Mac release binary name change in v0.8.0 release

kt3k
kt3k approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k
Copy link
Member

kt3k commented Jun 5, 2023

Note: We originally use _arm64 suffix for aarch64 https://github.com/denoland/deno_bindgen/pull/121/files#diff-38824eae137876b3842949ad05ee32be67c99c2905e12451429ba22010bcb937L35

@kt3k kt3k merged commit c88943f into denoland:main Jun 5, 2023
@skanehira skanehira deleted the fix-arm-darwin branch June 5, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skanehira @kt3k