optimize(core): move internal js src off heap

core/runtime.rs

@@ -413,6 +413,43 @@ impl JsRuntime {
     }
   }
 
+  /// Same as execute() except intended for internal runtime JS code
+  /// exposed to v8 as external strings to reduce heap-usage (~1MB) per-isolate
+  pub fn execute_static(
+    &mut self,
+    js_filename: &'static str,
+    js_source: &'static str,
+  ) -> Result<(), AnyError> {
+    let context = self.global_context();
+
+    let scope = &mut v8::HandleScope::with_context(self.v8_isolate(), context);
+
+    let source =
+      v8::String::new_external_onebyte_static(scope, js_source).unwrap();
+    let name =
+      v8::String::new_external_onebyte_static(scope, js_filename).unwrap();
+    let origin = bindings::script_origin(scope, name);
+
+    let tc_scope = &mut v8::TryCatch::new(scope);
+
+    let script = match v8::Script::compile(tc_scope, source, Some(&origin)) {
+      Some(script) => script,
+      None => {
+        let exception = tc_scope.exception().unwrap();
+        return exception_to_err_result(tc_scope, exception, false);
+      }
+    };
+
+    match script.run(tc_scope) {
+      Some(_) => Ok(()),
+      None => {
+        assert!(tc_scope.has_caught());
+        let exception = tc_scope.exception().unwrap();
+        exception_to_err_result(tc_scope, exception, false)
+      }
+    }
+  }
+
   /// Takes a snapshot. The isolate should have been created with will_snapshot
   /// set to true.
   ///

op_crates/crypto/lib.rs

@@ -22,7 +22,7 @@ pub fn init(isolate: &mut JsRuntime) {
     include_str!("01_crypto.js"),
   )];
   for (url, source_code) in files {
-    isolate.execute(url, source_code).unwrap();
+    isolate.execute_static(url, source_code).unwrap();
   }
 }
 

op_crates/fetch/26_fetch.js

@@ -333,7 +333,7 @@
       requiredArguments("FormData.set", arguments.length, 2);
       name = String(name);
 
-      // If there are any entries in the context object’s entry list whose name
+      // If there are any entries in the context object's entry list whose name
       // is name, replace the first such entry with entry and remove the others
       let found = false;
       let i = 0;
@@ -350,7 +350,7 @@
         i++;
       }
 
-      // Otherwise, append entry to the context object’s entry list.
+      // Otherwise, append entry to the context object's entry list.
       if (!found) {
         this[dataSymbol].push([name, parseFormDataValue(value, filename)]);
       }

op_crates/fetch/lib.rs

@@ -77,7 +77,7 @@ pub fn init(isolate: &mut JsRuntime) {
     ),
   ];
   for (url, source_code) in files {
-    isolate.execute(url, source_code).unwrap();
+    isolate.execute_static(url, source_code).unwrap();
   }
 }
 

op_crates/web/02_event.js

@@ -916,7 +916,7 @@
           // If signal is not null and its aborted flag is set, then return.
           return;
         } else {
-          // If listener’s signal is not null, then add the following abort
+          // If listener's signal is not null, then add the following abort
           // abort steps to it: Remove an event listener.
           signal.addEventListener("abort", () => {
             this.removeEventListener(type, callback, options);

op_crates/web/21_filereader.js

@@ -10,18 +10,18 @@
 
     fr.aborting = false;
 
-    // 1. If fr’s state is "loading", throw an InvalidStateError DOMException.
+    // 1. If fr's state is "loading", throw an InvalidStateError DOMException.
     if (fr.readyState === FileReader.LOADING) {
       throw new DOMException(
         "Invalid FileReader state.",
         "InvalidStateError",
       );
     }
-    // 2. Set fr’s state to "loading".
+    // 2. Set fr's state to "loading".
     fr.readyState = FileReader.LOADING;
-    // 3. Set fr’s result to null.
+    // 3. Set fr's result to null.
     fr.result = null;
-    // 4. Set fr’s error to null.
+    // 4. Set fr's error to null.
     fr.error = null;
 
     // 5. Let stream be the result of calling get stream on blob.
@@ -79,9 +79,9 @@
               return;
             }
 
-            // 1. Set fr’s state to "done".
+            // 1. Set fr's state to "done".
             fr.readyState = FileReader.DONE;
-            // 2. Let result be the result of package data given bytes, type, blob’s type, and encodingName.
+            // 2. Let result be the result of package data given bytes, type, blob's type, and encodingName.
             const size = chunks.reduce((p, i) => p + i.byteLength, 0);
             const bytes = new Uint8Array(size);
             let offs = 0;
@@ -115,7 +115,7 @@
               fr.dispatchEvent(ev);
             }
 
-            // 5. If fr’s state is not "loading", fire a progress event called loadend at the fr.
+            // 5. If fr's state is not "loading", fire a progress event called loadend at the fr.
             //Note: Event handler for the load or error events could have started another load, if that happens the loadend event for this load is not fired.
             if (fr.readyState !== FileReader.LOADING) {
               const ev = new ProgressEvent("loadend", {
@@ -143,7 +143,7 @@
           fr.dispatchEvent(ev);
         }
 
-        //If fr’s state is not "loading", fire a progress event called loadend at fr.
+        //If fr's state is not "loading", fire a progress event called loadend at fr.
         //Note: Event handler for the error event could have started another load, if that happens the loadend event for this load is not fired.
         if (fr.readyState !== FileReader.LOADING) {
           const ev = new ProgressEvent("loadend", {});

op_crates/web/lib.deno_web.d.ts

@@ -102,7 +102,7 @@ declare class EventTarget {
      *
      * When set to true, options's passive indicates that the callback will not
      * cancel the event by invoking preventDefault(). This is used to enable
-     * performance optimizations described in § 2.8 Observing event listeners.
+     * performance optimizations described in section 2.8 Observing event listeners.
      *
      * When set to true, options's once indicates that the callback will only be
      * invoked once after which the event listener will be removed.

op_crates/web/lib.rs

@@ -55,7 +55,7 @@ pub fn init(isolate: &mut JsRuntime) {
     ),
   ];
   for (url, source_code) in files {
-    isolate.execute(url, source_code).unwrap();
+    isolate.execute_static(url, source_code).unwrap();
   }
 }
 

op_crates/webgpu/lib.rs

@@ -104,7 +104,7 @@ pub fn init(isolate: &mut deno_core::JsRuntime) {
     ),
   ];
   for (url, source_code) in files {
-    isolate.execute(url, source_code).unwrap();
+    isolate.execute_static(url, source_code).unwrap();
   }
 }
 

op_crates/websocket/lib.rs

@@ -343,7 +343,7 @@ pub async fn op_ws_next_event(
 /// Load and execute the javascript code.
 pub fn init(isolate: &mut JsRuntime) {
   isolate
-    .execute(
+    .execute_static(
       "deno:op_crates/websocket/01_websocket.js",
       include_str!("01_websocket.js"),
     )

runtime/js/02_console.js

@@ -35,20 +35,21 @@
     return ArrayBuffer.isView(x) && !(x instanceof DataView);
   }
 
-  const tableChars = {
-    middleMiddle: "─",
-    rowMiddle: "┼",
-    topRight: "┐",
-    topLeft: "┌",
-    leftMiddle: "├",
-    topMiddle: "┬",
-    bottomRight: "┘",
-    bottomLeft: "└",
-    bottomMiddle: "┴",
-    rightMiddle: "┤",
-    left: "│ ",
-    right: " │",
-    middle: " │ ",
+  // Strings are escaped so all JS source is ASCII
+  var tableChars = {
+    bottomLeft: "\u2514",
+    bottomMiddle: "\u2534",
+    bottomRight: "\u2518",
+    left: "\u2502 ",
+    leftMiddle: "\u251c",
+    middle: " \u2502 ",
+    middleMiddle: "\u2500",
+    right: " \u2502",
+    rightMiddle: "\u2524",
+    rowMiddle: "\u253c",
+    topLeft: "\u250c",
+    topMiddle: "\u252c",
+    topRight: "\u2510",
   };
 
   function isFullWidthCodePoint(code) {