Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(std/node): fix assertStats and assertStatsBigInt if atime, mtime or birthtime are null #9311

Merged
merged 1 commit into from
Jan 29, 2021
Merged

test(std/node): fix assertStats and assertStatsBigInt if atime, mtime or birthtime are null #9311

merged 1 commit into from
Jan 29, 2021

Conversation

Liamolucko
Copy link
Contributor

@Liamolucko Liamolucko commented Jan 28, 2021 •
edited
Loading

All the tests related to std/node stat() and lstat() would previously fail if atime, mtime or birthtime were null. This was because optional chaining always returns undefined (so null?.foo === undefined) and Number(null) === 0.

@Liamolucko Liamolucko mentioned this pull request Jan 28, 2021
Merged
ry
ry approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ry ry merged commit d405e57 into denoland:master Jan 29, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @caspervonb
test(node): fix assertStats if atime, mtime or birthtime are null (d…
e8caf47 
…enoland/deno#9311)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @caspervonb
test(node): fix assertStats if atime, mtime or birthtime are null (d…
841e5bb 
…enoland/deno#9311)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @caspervonb
test(node): fix assertStats if atime, mtime or birthtime are null (d…
f4979f7 
…enoland/deno#9311)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @denobot
test(node): fix assertStats if atime, mtime or birthtime are null (d…
ace3870 
…enoland/deno#9311)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@Liamolucko @denobot
test(node): fix assertStats if atime, mtime or birthtime are null (d…
bfe3281 
…enoland/deno#9311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Liamolucko @ry