Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Standalone lite binaries and cross compilation #9141

Merged
merged 8 commits into from
Jan 19, 2021
Merged

feat: Standalone lite binaries and cross compilation #9141

merged 8 commits into from
Jan 19, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jan 17, 2021 •
edited
Loading

This commit adds --target and --lite flags to deno compile subcommand.

--target allows to cross-compile binary to different target architectures by
fetching appropriate binary from remote server on first run. All downloaded
binaries are stored in "$DENO_DIR/dl".

--lite allows to use lite version of the runtime (ie. the one that doesn't contain
built-in tooling like formatter or linter).

@lucacasonato lucacasonato added this to the 1.7.0 milestone Jan 17, 2021
bartlomieju
bartlomieju commented Jan 17, 2021
View reviewed changes
cli/flags.rs Outdated Show resolved Hide resolved
cli/tools/standalone.rs Show resolved Hide resolved
cli/tools/standalone.rs Outdated Show resolved Hide resolved
cli/tools/standalone.rs Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request Jan 17, 2021
Closed
22 tasks
@bartlomieju bartlomieju changed the title [WIP] feat: Standalone lite binaries and cross compilation feat: Standalone lite binaries and cross compilation Jan 18, 2021
lucacasonato
lucacasonato approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great feature to have. I am somewhat concerned about this root certificate thing, but lets cross that bridge once someone reports it as an issue :-)

ry
ry reviewed Jan 18, 2021
View reviewed changes
cli/flags.rs Outdated Show resolved Hide resolved
ry
ry approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 9ff468d into denoland:master Jan 19, 2021
@bartlomieju bartlomieju deleted the standalone_lite_binaries branch January 19, 2021 02:40
@rgwood rgwood mentioned this pull request Mar 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlomieju @ry @lucacasonato