Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op_crates/web): Use WorkerLocation for location in workers #9084

Merged
merged 1 commit into from
Jan 17, 2021
Merged

fix(op_crates/web): Use WorkerLocation for location in workers #9084

merged 1 commit into from
Jan 17, 2021

Conversation

nayeemrmn
Copy link
Collaborator

  • fix(op_crates/web): Strip username and password from location

Includes #9044.

@nayeemrmn nayeemrmn mentioned this pull request Jan 11, 2021
Closed
@nayeemrmn nayeemrmn force-pushed the worker-location branch 4 times, most recently from 7b6dcd1 to 0b18993 Compare January 13, 2021 17:49
lucacasonato
lucacasonato reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments.

cli/tests/070_location.ts Outdated Show resolved Hide resolved
cli/tests/071_location_unset.ts Outdated Show resolved Hide resolved
cli/tests/079_location_authentication.ts Outdated Show resolved Hide resolved
cli/tests/subdir/worker_location.ts Outdated Show resolved Hide resolved
cli/tests/workers_test.ts Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn force-pushed the worker-location branch 2 times, most recently from ab2d91b to 29ba7e6 Compare January 16, 2021 03:20
bartlomieju
bartlomieju approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 7db0605 into denoland:master Jan 17, 2021
@nayeemrmn nayeemrmn deleted the worker-location branch January 17, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayeemrmn @lucacasonato @bartlomieju