Implement file create #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkassimo
reviewed
Oct 5, 2018
js/files_test.ts
Outdated
|
|
||
| test(async function createFileSuccess() { | ||
| const path = "test.txt"; | ||
| let f = await deno.create(path); |
There was a problem hiding this comment.
Could you create the test file in a temporary directory? Like using a path given by deno.makeTempDir
ry
reviewed
Oct 5, 2018
| export async function create(filename: string): Promise<File> { | ||
| const builder = new flatbuffers.Builder(); | ||
| const filename_ = builder.createString(filename); | ||
| msg.Create.startCreate(builder); |
There was a problem hiding this comment.
I think this doesn’t need a separate msg. We should be able to reuse Open.
|
|
||
| table CreateRes { | ||
| rid: int; | ||
| } |
There was a problem hiding this comment.
Reuse Open/OpenRes instead of adding this.
| @@ -558,6 +559,41 @@ fn op_mkdir( | |||
| }) | |||
| } | |||
|
|
|||
| fn op_create( | |||
|
@ry I think permission mode should be completed before restart it. Next I will try to work on permission design. |
|
If |
|
@ztplz I'm going to close this one as it's getting dated - if you come back to this project please open a new PR and link to this one. Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior art:
go: func Create(name string) (*File, error)rust: tokio::fs::File::create<P>(path: P) -> CreateFuture<P>