Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade: dprint, swc_bundler, swc_common, swc_ecmascript #8901

Merged
merged 4 commits into from
Dec 28, 2020
Merged

upgrade: dprint, swc_bundler, swc_common, swc_ecmascript #8901

merged 4 commits into from
Dec 28, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 28, 2020 •
edited
Loading

Closes #8828
Closes #8770
Closes #8746
Closes #8736
Closes #8734
Closes #8725
Closes #8722
Closes #8680
Closes #8679
Closes #8620
Closes #8597
Closes #8545
Closes #8541
Closes #8285
Closes #8211

@bartlomieju bartlomieju changed the title upgrade: dprint, swc upgrade: dprint, swc_bundler, swc_common, swc_ecmascript Dec 28, 2020
@bartlomieju
Copy link
Member Author

bartlomieju commented Dec 28, 2020 •
edited
Loading

@kitsonk standalone_no_module_load fails because dynamic import is getting bundled, could you point me to a place where module graph decides if dynamic imports should be bundled?

Most likely problem in SWC itself

Fixed in swc_bundler 0.18.2

kitsonk
kitsonk approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 24844a0 into denoland:master Dec 28, 2020
@bartlomieju bartlomieju deleted the upgrade_swc branch December 28, 2020 23:22
@cmorten cmorten mentioned this pull request Dec 29, 2020
Closed
@bartlomieju bartlomieju mentioned this pull request Dec 30, 2020
Closed
@cmd-johnson cmd-johnson mentioned this pull request May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bartlomieju @kitsonk