Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): respect enable flag for requests #8850

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Dec 22, 2020

This PR fixes situations with the lsp, where the extension is disable, but on hover and other requests, there are duplicate values reported to vscode.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kitsonk kitsonk merged commit b091c6c into denoland:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants