Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(std/node): resolve files in symlinked directories #8840

Merged
merged 4 commits into from
Jan 5, 2021
Merged

fix(std/node): resolve files in symlinked directories #8840

merged 4 commits into from
Jan 5, 2021

Conversation

Liamolucko
Copy link
Contributor

Fixes #3867

bartlomieju
bartlomieju requested changes Dec 25, 2020
View reviewed changes
std/node/module_test.ts Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Liamolucko

@bartlomieju bartlomieju merged commit 4c4791b into denoland:master Jan 5, 2021
@Liamolucko Liamolucko deleted the require_pnpm branch January 6, 2021 04:11
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@Liamolucko
fix(std/node): resolve files in symlinked directories (denoland/deno#…
a28e7f6 
…8840)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@Liamolucko
fix(node): resolve files in symlinked directories (denoland/deno#8840)
e998272
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@Liamolucko @caspervonb
fix(node): resolve files in symlinked directories (denoland/deno#8840)
7999db7
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@Liamolucko @caspervonb
fix(node): resolve files in symlinked directories (denoland/deno#8840)
fdf1d6e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @caspervonb
fix(node): resolve files in symlinked directories (denoland/deno#8840)
404d125
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @caspervonb
fix(node): resolve files in symlinked directories (denoland/deno#8840)
c11eb1a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @caspervonb
fix(node): resolve files in symlinked directories (denoland/deno#8840)
6c907b9
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@Liamolucko @denobot
fix(node): resolve files in symlinked directories (denoland/deno#8840)
47233a2
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@Liamolucko @denobot
fix(node): resolve files in symlinked directories (denoland/deno#8840)
55930c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PNPM and createRequire not working
2 participants
@Liamolucko @bartlomieju