Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(std/wasi): add a case for open directory/../.. #8708

Conversation

caspervonb
Copy link
Contributor

This adds a test case to ensure that we can't escape by going down a
directory before dotting our way out of it.

This adds a test case to ensure that we can't escape by going down a
directory before dotting our way out of it.
@caspervonb
Copy link
Contributor Author

caspervonb commented Dec 10, 2020

Aside, I should probably ship the sources next to the binaries in wasi-test-suite for more readable diffs and code coverage. Not really relevant for us until coverage supports DWARF tho.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@lucacasonato lucacasonato merged commit 65c6a03 into denoland:master Dec 10, 2020
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants