feat(lsp): basic support for textDocument/completion #8651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
changed the title
lucacasonato
force-pushed
the
lsp-completions
branch
from
f481125
to
fee18ec
Compare
lucacasonato
force-pushed
the
lsp-completions
branch
from
fee18ec
to
c9f570b
Compare
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic
textDocument/completionhandling.Currently text completions with
TextEdits do not work. I have not managed to figure out why though. Until I find the cause I have disabled theincludeCompletionsWithInsertTextTS user preference which should mitigate this.In the future we should implement
completionItem/resolveto supportdocumentationanddetailsfield in theCompletionItem.