Implement 'AsyncRefCell' and 'ResourceTable2' #8273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
changed the title
piscisaureus
force-pushed
the
tok
branch
3 times, most recently
from
d2df810
to
25a9007
Compare
|
Unfortunately it did not, and I do know why, and it is complicated ... |
piscisaureus
changed the title
|
Far from green, but this works: |
|
I ran the benchmarks - there is some minimal performance degradation on linux (~5% slower) |
ry
reviewed
Nov 24, 2020
ry
reviewed
Nov 24, 2020
| @@ -34,6 +34,7 @@ pub enum Op { | |||
| /// Maintains the resources and ops inside a JS runtime. | |||
| pub struct OpState { | |||
| pub resource_table: crate::ResourceTable, | |||
| pub resource_table_2: crate::resources2::ResourceTable, | |||
bartlomieju
reviewed
Nov 24, 2020
Comment on lines
+112
to
+117
| /// cause the resource to be dropped. However, since resources are reference | ||
| /// counted, therefore pending ops are not automatically cancelled. |
There was a problem hiding this comment.
Is this intentional design? I thought the main point of close is to drop pending ops for the resource.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Nov 24, 2020
piscisaureus
changed the title
ry
approved these changes
Nov 25, 2020
| assert!(cell.try_borrow_mut().is_none()); | ||
| assert!(cell.try_borrow().is_some()); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.