Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(std/wasi): re-enable clock_time_get tests #8098

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Oct 24, 2020

This brings in revised tests for clock_time_get from upstream and re-enables them.

This revision of these tests allow for lower precision clocks (we only provide millisecond precision, and that is conformant but my previous tests for this in the upstream test suite were a bit more aggressive).

@caspervonb

This comment has been minimized.

This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but my previous
tests for this in the upstream test suite were a bit more aggressive).
@caspervonb caspervonb force-pushed the test-std-wasi-re-enable-clock-time-get-tests branch from 9e68f12 to 00049f6 Compare October 24, 2020 20:09
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit b9dc2c3 into denoland:master Oct 26, 2020
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
This brings in revised tests for clock_time_get from upstream and
re-enables them.

This revision of these tests allow for lower precision clocks (we only
provide millisecond precision, and that is conformant but previous
tests for this in the upstream test suite were a bit more aggressive).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants