Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(std/io): remove trivial internal util.ts module #8032

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Oct 19, 2020

This removes the internal (but poorly named) util.ts module as it only contained some very trivial one liner helpers.

Closes #8029 as it removes the entire module.

This removes the internal (but poorly named) util.ts module as it
only contained some very trivial one liner helpers.
@caspervonb
Copy link
Contributor Author

caspervonb commented Oct 19, 2020

Technically a breaking change but this i believe this to be a case of "Casper don't freak everyone out by tagging everything as breaking"(PTAL @ry ) 😅

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. std is still unstable, so I wouldn't consider this a breaking change :-)

@lucacasonato lucacasonato merged commit 17467d0 into denoland:master Oct 20, 2020
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tempFile function from std/io/util.ts
2 participants