-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(unstable): enable importsNotUsedAsValues by default (#7413)" #7800
Conversation
…oland#7413)" This reverts commit fbb18d4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - before merging I want to confirm that this case gets stripped correctly now:
import { MyType } from "./foo.ts";
export type { MyType };
Actually, just after opening this I realised the re-export thing was still broken and fixed it in swc: swc-project/swc#1126. Reiterating that I don't think these temporary swc bugs justify imposing rules for type checking so it breaks there, too. That's for fundamental incompatibilities, like how |
Also I think this change and that swc fix will both release at our next version. |
Yeah lets merge this then. As it is fixed upstream we will get the fix in Deno before 1.4.5 is released. |
…land#7413" (denoland#7800) This reverts commit fbb18d4.
…land#7413" (denoland#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
…land/deno#7413" (denoland/deno#7800) This reverts commit fbb18d4.
This reverts commit fbb18d4.
Ref #7413.
As discussed, the
--no-check
incompatiblity we were seeing withimport { MyType } from "./file.ts";
was a symptom of swc-project/swc#1065 which is now fixed. The ruleis no longerwas never really needed.