upgrade: swc, deno_doc, deno_lint, dprint #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
force-pushed
the
update_crates
branch
from
490381e to
b8fd744
Compare
bartlomieju
commented
Oct 2, 2020
Comment on lines
+1033
to
+1039
| // FIXME(bartlomieju): had to add space in `<div>`, probably a quirk in swc_ecma_codegen | ||
| assert!( | ||
| h.cache_calls[0] | ||
| .2 | ||
| .to_string() | ||
| .unwrap() | ||
| .contains("<div>Hello world!</div>"), | ||
| .contains("<div >Hello world!</div>"), |
There was a problem hiding this comment.
Little quirk I encountered; but it should still be ok to land.
Full output after transform:
export default class A {
render() {
return <div >Hello world!</div>;
}
};
//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIjxodHRwczovL2Rlbm8ubGFuZC94L3RyYW5zcGlsZS50c3g+Il0sInNvdXJjZXNDb250ZW50IjpbImV4cG9ydCBkZWZhdWx0IGNsYXNzIEEge1xuICByZW5kZXIoKSB7XG4gICAgcmV0dXJuICg8ZGl2PkhlbGxvIHdvcmxkITwvZGl2Pik7XG4gIH1cbn1cbiJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoicUJBQUEsQ0FBQTtBQUNBLFVBQUE7Z0JBQ0EsR0FBQSxFQUFBLFlBQUEsRUFBQSxHQUFBIn0=
There was a problem hiding this comment.
JavascriptMick
pushed a commit
to JavascriptMick/deno
that referenced
this pull request
Oct 5, 2020
Soremwar
pushed a commit
to Soremwar/deno
that referenced
this pull request
Oct 6, 2020
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.