Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/installer): Add missing flags for deno install #7601

Merged
merged 2 commits into from
Oct 19, 2020
Merged

feat(cli/installer): Add missing flags for deno install #7601

merged 2 commits into from
Oct 19, 2020

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Sep 20, 2020 •
edited
Loading

Adds:

  • deno install --importmap
  • deno install --no-remote
  • deno install --lock
  • deno install --lock-write
  • deno install --cached-only
  • deno install --v8-flags
  • deno install --seed
  • deno install --inspect
  • deno install --inspect-brk

Closes #3929.
Closes #7354.

@nayeemrmn nayeemrmn mentioned this pull request Sep 20, 2020
Closed
@ry ry added this to the 1.5.0 milestone Sep 21, 2020
@ry
Copy link
Member

ry commented Sep 21, 2020

Looks good - thanks @nayeemrmn. I think this should wait for 1.5.0?

@nayeemrmn nayeemrmn force-pushed the install-missing-flags branch from 564c60a to cfe0266 Compare September 27, 2020 11:53
@nayeemrmn nayeemrmn force-pushed the install-missing-flags branch 2 times, most recently from 0755c76 to 0e26db5 Compare October 14, 2020 16:29
@nayeemrmn nayeemrmn force-pushed the install-missing-flags branch from 0e26db5 to faea0eb Compare October 14, 2020 21:29
bartlomieju
bartlomieju approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 3f55137 into denoland:master Oct 19, 2020
@nayeemrmn nayeemrmn deleted the install-missing-flags branch October 19, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crypt096 crypt096 crypt096 approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

deno install does not support import maps
4 participants
@nayeemrmn @ry @bartlomieju @crypt096