fix(std/testing): sanitize escape sequences from assertion errors #7516
Conversation
There was a problem hiding this comment.
I've been meaning to add Deno.InspectOptions::color = true, which can be set to false here, stopping Deno.inspect() from adding stylistic colour while preserving colour in the inspected value (so only they can be escaped like in this PR). We need that before we can apply this fix.
| ? stripColor(Deno.inspect(v, { | ||
| ? Deno.inspect(v, { |
There was a problem hiding this comment.
The intention of stripColor() here is to strip the colour that's added stylistically by Deno.inspect() based on types. This change will make regular objects look like this:
> deno eval 'console.log(Deno.inspect([123456789, 123456789, 123456789, 123456789, 123456789, 123456789, 123456789]).replaceAll("\x1b", "<esc>"))'
[
<esc>[33m123456789<esc>[39m,
<esc>[33m123456789<esc>[39m,
<esc>[33m123456789<esc>[39m,
<esc>[33m123456789<esc>[39m,
<esc>[33m123456789<esc>[39m,
<esc>[33m123456789<esc>[39m,
<esc>[33m123456789<esc>[39m
]
There was a problem hiding this comment.
his change will make regular objects look
Currently only sanitizing string inputs so that's not the case as-is; but suppose there's an edge case there with objects that have string properties with escape sequences in them.
There was a problem hiding this comment.
But actually; this should be handled at a lower level so I'll end up reverting that.
|
This should be fixed in inspect instead. |
No description provided.