Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(std/path): Align globToRegExp() with bash glob expansion #7209

Merged
merged 2 commits into from
Oct 1, 2020
Merged

feat(std/path): Align globToRegExp() with bash glob expansion #7209

merged 2 commits into from
Oct 1, 2020

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Aug 26, 2020 •
edited
Loading

  • feat: Support escaping glob characters
  • feat: Support more character classes
  • feat: Match characters literally on segment parse failure
  • fix: Match nothing for empty globs
  • fix: Contain any glob syntax to its path segment
  • perf: Remove extraneous separators from generated regex
  • doc: Add detailed JSDoc
  • chore: Remove old copyright headers

More details in the JSDoc.

@nayeemrmn nayeemrmn marked this pull request as draft August 29, 2020 20:59
@nayeemrmn nayeemrmn marked this pull request as ready for review September 15, 2020 18:26
@nayeemrmn nayeemrmn marked this pull request as draft September 15, 2020 18:27
@nayeemrmn nayeemrmn marked this pull request as draft September 15, 2020 18:27
@nayeemrmn
feat(std/path): Improve globToRegExp()
72d4297 
- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
@nayeemrmn nayeemrmn marked this pull request as ready for review September 15, 2020 19:26
@nayeemrmn
Copy link
Collaborator Author

@ry Please review.

ry
ry reviewed Sep 16, 2020
View reviewed changes
std/fs/expand_glob.ts Outdated Show resolved Hide resolved
ry
ry reviewed Sep 16, 2020
View reviewed changes
std/path/glob.ts Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great PR @nayeemrmn

@bartlomieju bartlomieju merged commit 326ccb1 into denoland:master Oct 1, 2020
@nayeemrmn nayeemrmn deleted the glob-to-regexp branch October 1, 2020 10:52
Soremwar pushed a commit to Soremwar/deno that referenced this pull request Oct 6, 2020
@nayeemrmn @Soremwar
feat(std/path): Align globToRegExp() with bash glob expansion (denola…
8eb6b3c 
…nd#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@nayeemrmn
feat(std/path): Align globToRegExp() with bash glob expansion (denola…
a713757 
…nd/deno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
0b7b734 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
74473a8 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
dd16cc3 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
30f72f0 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
d292a3f 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
68652a8 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @denobot
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
912379d 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@nayeemrmn @denobot
feat(path): Align globToRegExp() with bash glob expansion (denoland/d…
d93563d 
…eno#7209)

- feat: Support escaping glob characters
- feat: Support more character classes
- feat: Match characters literally on segment parse failure
- fix: Match nothing for empty globs
- fix: Contain any glob syntax to its path segment
- perf: Remove extraneous separators from generated regex
- doc: Add detailed JSDoc
- chore: Remove old copyright headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayeemrmn @ry @bartlomieju