Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix std/node/assert misnamed exports, close #7102 #7123

Merged
merged 9 commits into from
Aug 20, 2020
Merged

Fix std/node/assert misnamed exports, close #7102 #7123

merged 9 commits into from
Aug 20, 2020

Commits on Aug 19, 2020

  1. feat(std/node/assert): add ok() 

    ref: denoland#7102
    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    b409377 View commit details
    Browse the repository at this point in the history

  2. test(std/node/assert): ensure that fail() is exposed

    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    5f77b58 View commit details
    Browse the repository at this point in the history

  3. feat(std/testing/asserts): implement assertNotStrictEquals()

    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    beddeb0 View commit details
    Browse the repository at this point in the history

  4. refactor(std/testing/asserts): remove useless diffing code from `asse… 

    …rtNotStrictEquals()`
    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1fc6926 View commit details
    Browse the repository at this point in the history

  5. fix(std/node/assert): rename exports to match their expected behaviou… 

    …r based on corresponding Node.js docs

The incorrectly referred (misnamed) methods are deprecated anyway.

Ref: https://nodejs.org/dist/latest-v14.x/docs/api/assert.html

Closes denoland#7102
    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    4f49ddd View commit details
    Browse the repository at this point in the history

  6. feat(std/node/assert): add notStrictEqual()

    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    d29643d View commit details
    Browse the repository at this point in the history

  7. refactor(std/node/assert): make assert() the default export

    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a46e150 View commit details
    Browse the repository at this point in the history

  8. test(std/testing/asserts): don't use explicit any

    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c141ada View commit details
    Browse the repository at this point in the history

  9. chore(std/node/assert): format source files correctly

    @schwarzkopfb
    schwarzkopfb committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a14023d View commit details
    Browse the repository at this point in the history