Deno.core.dispatch uses op name instead of id #6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Jun 20, 2020
| @@ -1,7 +1,6 @@ | |||
| // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license. | |||
| import * as util from "../util.ts"; | |||
| import { core } from "../core.ts"; | |||
| import { OPS_CACHE } from "../runtime.ts"; | |||
There was a problem hiding this comment.
Removes OPS_CACHE indirection which was once problematic place when trying to snapshot ES modules
| @@ -1,22 +1,12 @@ | |||
| // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license. | |||
|
|
|||
| import { sendAsyncMinimal, sendSyncMinimal } from "./dispatch_minimal.ts"; | |||
| // TODO(bartlomieju): remove this import and maybe lazy-initialize | |||
| // OPS_CACHE that belongs only to this module | |||
| import { OPS_CACHE } from "../runtime.ts"; | |||
| Object.assign(window.Deno.core, { | ||
| setAsyncHandler, | ||
| dispatch: send, | ||
| dispatchByName: dispatch, |
There was a problem hiding this comment.
name to be determined
core/core.js
Outdated
| @@ -181,9 +183,14 @@ SharedQueue Binary Layout | |||
| } | |||
| } | |||
|
|
|||
| function dispatch(opName, control, zeroCopy) { | |||
| return send(opsCache[opName], control, zeroCopy); | |||
There was a problem hiding this comment.
worth to do an assert that resulting opId is not undefined?
Comment on lines
+26
to
28
| for (const [name, opId] of Object.entries(opsMap)) { | ||
| core.setAsyncHandler(opId, getAsyncHandler(name)); | ||
| } |
There was a problem hiding this comment.
Async handler registration is the last API bit that's a bit strange IMO and could be structured better
|
Benchmarks
|
|
Probably need a couple of other samples from benchmarks in order to draw any conclusions. I would suggest doing a release build locally and hitting tools/deno_tcp.ts with wrk manually to get a better sense. |
|
@ry sure, here are better benchmarks Benchmark:
|
bartlomieju
changed the title
ry
approved these changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.