Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change plugin interface to prevent segfaults when unloading plugin #5210

Merged
merged 1 commit into from
May 11, 2020
Merged

Change plugin interface to prevent segfaults when unloading plugin #5210

merged 1 commit into from
May 11, 2020

Conversation

piscisaureus
Copy link
Member

@piscisaureus piscisaureus commented May 10, 2020 •
edited
Loading

Fixes: #3473
Closes: #5193

piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 10, 2020
@piscisaureus
WIP: change plugin interface to avoid unloading plugin before it's sa…
fc42ccf 
…fe (denoland#5210)

I seem to have solved the crashes related to the plugin's op dispatchers
and op futures getting dropped after the plugin is unloaded.

However `runTestPluginClose()` still crashes, it's not quite clear to me
yet what causes it.
afinch7
afinch7 reviewed May 11, 2020
View reviewed changes
test_plugin/src/lib.rs Outdated Show resolved Hide resolved
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 11, 2020
@piscisaureus
Change plugin interface to prevent segfaults when unloading it (denol…
0b50bdd 
…and#5210)
@piscisaureus piscisaureus changed the title WIP: change plugin interface to avoid unloading plugin before it's safe Change plugin interface to prevent segfaults when unloading it May 11, 2020
@piscisaureus piscisaureus requested a review from ry May 11, 2020 18:48
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 11, 2020
@piscisaureus
Change plugin interface to prevent segfaults when unloading plugin (d…
123c0c5 
…enoland#5210)

Fixes: denoland#3473
Closes: denoland#5193
@piscisaureus piscisaureus changed the title Change plugin interface to prevent segfaults when unloading it Change plugin interface to prevent segfaults when unloading plugin May 11, 2020
ry
ry approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

afinch7
afinch7 approved these changes May 11, 2020
View reviewed changes
core/plugin_api.rs Show resolved Hide resolved
@piscisaureus piscisaureus merged commit 3cccadc into denoland:master May 11, 2020
@piscisaureus piscisaureus deleted the plugin branch May 11, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@afinch7 afinch7 afinch7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin test is flaky on windows
3 participants
@piscisaureus @ry @afinch7