Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Remove support for .wasm imports #5135

Merged
merged 4 commits into from
May 7, 2020
Merged

BREAKING: Remove support for .wasm imports #5135

merged 4 commits into from
May 7, 2020

Commits on May 7, 2020

  1. BREAKING: Remove support for .wasm imports 

    Importing .wasm files is non-standardized therefore deciding to
support current functionality past 1.0 release is risky.

Besides that .wasm import posed many challenges in our codebase
due to complex interactions with TS compiler which spawned
thread for each encountered .wasm import.

This commit removes:
- cli/compilers/wasm.rs
- cli/compilers/wasm_wrap.js
- two integration tests related to .wasm imports
    @bartlomieju
    bartlomieju committed May 7, 2020
    Configuration menu
    Copy the full SHA
    23981b2 View commit details
    Browse the repository at this point in the history

  2. lint

    @bartlomieju
    bartlomieju committed May 7, 2020
    Configuration menu
    Copy the full SHA
    31576dc View commit details
    Browse the repository at this point in the history

  3. remove wasm import from manual

    @bartlomieju
    bartlomieju committed May 7, 2020
    Configuration menu
    Copy the full SHA
    44ded2e View commit details
    Browse the repository at this point in the history

  4. rename to match TOC

    @bartlomieju
    bartlomieju committed May 7, 2020
    Configuration menu
    Copy the full SHA
    b907317 View commit details
    Browse the repository at this point in the history