Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ProcessStatus into three variants #4966

Closed
wants to merge 2 commits into from

Conversation

bartlomieju
Copy link
Member

No description provided.

@ry ry mentioned this pull request Apr 28, 2020
43 tasks
@bartlomieju bartlomieju requested a review from ry April 28, 2020 15:04
@ry
Copy link
Member

ry commented Apr 28, 2020

[12:02, 4/28/2020] Bartek:

error TS2339: Property 'code' does not exist on type '{ success: false; code: number; } | { success: false; signal: number; }'.
  Property 'code' does not exist on type '{ success: false; signal: number; }'.
    assert(status.code);
                  ~~~~
    at file:///Users/biwanczuk/dev/deno/cli/js/tests/process_test.ts:42:19

adding assertions doesn't really help
[12:03, 4/28/2020] Bartek: I'm not sure this change is good

@ry ry closed this Apr 28, 2020
@bartlomieju bartlomieju deleted the make_process_status branch April 28, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants