Make shutdown unstable and async #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
commented
Apr 27, 2020
cli/js/ops/net.ts
Outdated
Comment on lines
25
to
26
| export async function shutdown(rid: number, how: ShutdownMode): Promise<void> { | ||
| return sendSync("op_shutdown", { rid, how }); |
There was a problem hiding this comment.
@ry You said to make this async. Actually make the op async or just the exposed function for futureproofing?
There was a problem hiding this comment.
Future proofing is fine. Ultimately the op should be async.
|
@ry what's the reason for making this API async? It's sync in tokio API https://docs.rs/tokio/0.2.19/tokio/net/struct.TcpStream.html#method.shutdown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.