Make import maps unstable #4934

lucacasonato · 2020-04-27T19:04:19Z

I couldn't use State::check_unstable, because I need to check before I have a State instance to work with (inside State::new because I need to check before import map loading which occurs in State::new).

Fixes #4931

ry · 2020-04-27T19:11:21Z

cli/state.rs

+    api_name
+  );
+  std::process::exit(70);
+}


Nice - thanks!

Make import maps unstable

76eb725

ry reviewed Apr 27, 2020

View reviewed changes

cli/state.rs

api_name

);

std::process::exit(70);

}

Copy link

Member

ry Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks!

bartlomieju approved these changes Apr 27, 2020

View reviewed changes

bartlomieju merged commit e6f70c7 into denoland:master Apr 27, 2020

SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020

Make import maps unstable (denoland#4934)

9c527c4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make import maps unstable #4934

Make import maps unstable #4934

lucacasonato commented Apr 27, 2020 •

edited

Loading

ry Apr 27, 2020

Make import maps unstable #4934

Make import maps unstable #4934

Conversation

lucacasonato commented Apr 27, 2020 • edited Loading

ry Apr 27, 2020

Choose a reason for hiding this comment

lucacasonato commented Apr 27, 2020 •

edited

Loading