Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node polyfill for fs chown and close #4377

Merged
merged 4 commits into from
Mar 15, 2020
Merged

Node polyfill for fs chown and close #4377

merged 4 commits into from
Mar 15, 2020

Conversation

cknight
Copy link
Contributor

@cknight cknight commented Mar 14, 2020

This PR:

  • Adds Node fs.chown polyfill
  • Adds Node fs.close polyfill
  • Adds missing copyright notice

@cknight
Copy link
Contributor Author

cknight commented Mar 14, 2020

@ry - next set ready for review

ry
ry approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @cknight !

@ry ry merged commit a159165 into denoland:master Mar 15, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@cknight
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
9056941
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
1334646
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight @caspervonb
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
79ab3c3
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight @caspervonb
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
0d25379
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
1de61c8
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
12e9b3b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
3b7f258
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @denobot
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
ae376cd
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@cknight @denobot
Node polyfill for fs.chown and fs.close (denoland/deno#4377)
5297fff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknight @ry