Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] fix: CI failures on windows #4107

Closed
wants to merge 8 commits into from
Closed

[WIP] fix: CI failures on windows #4107

wants to merge 8 commits into from

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Feb 24, 2020

WIP

@bartlomieju bartlomieju mentioned this pull request Feb 24, 2020
Merged
@uki00a uki00a changed the title fix: CI failures on windows [WIP] fix: CI failures on windows Feb 25, 2020
@keroxp
Copy link
Contributor

keroxp commented Feb 25, 2020

@uki00a I saw your changes in PR (#4094) and found you added beforeEach dummy test instead of TLA. It may be the cause. test() is executed in parallel depending on the run setting.

@keroxp keroxp mentioned this pull request Feb 26, 2020
Merged
@uki00a
Copy link
Contributor Author

uki00a commented Mar 15, 2020 •
edited
Loading

Closed in favor of #4147.

@uki00a uki00a closed this Mar 15, 2020
@uki00a uki00a deleted the fix-ci-failures-on-windows branch March 17, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uki00a @keroxp