feat: Use Isolate.register_op in CLI, take 2 #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two subjects I'd like to fix before landing this change:
|
ry
reviewed
Oct 1, 2019
bartlomieju
commented
Oct 1, 2019
There was a problem hiding this comment.
@ry this PR is ready for review. I hit the wall for JS API - suggestions welcome.
Comment on lines
+38
to
+65
|
|
||
| i.register_op("read", state_.cli_op(minimal_op(io::op_read))); | ||
| i.register_op("write", state_.cli_op(minimal_op(io::op_write))); | ||
|
|
||
| i.register_op( | ||
| "exit", | ||
| state_.cli_op(json_op(state_.stateful_op(os::op_exit))), | ||
| ); | ||
| i.register_op( | ||
| "is_tty", | ||
| state_.cli_op(json_op(state_.stateful_op(os::op_is_tty))), | ||
| ); | ||
| i.register_op( | ||
| "env", | ||
| state_.cli_op(json_op(state_.stateful_op(os::op_env))), | ||
| ); | ||
| i.register_op( | ||
| "exec_path", | ||
| state_.cli_op(json_op(state_.stateful_op(os::op_exec_path))), | ||
| ); | ||
| i.register_op( | ||
| "utime", | ||
| state_.cli_op(json_op(state_.stateful_op(fs::op_utime))), | ||
| ); | ||
| i.register_op( | ||
| "set_env", | ||
| state_.cli_op(json_op(state_.stateful_op(os::op_set_env))), | ||
| ); |
There was a problem hiding this comment.
This is ripe for abstraction - we need to do it anyway, because there we still need to provide different ops for different workers (see #1858)
| export const OP_FETCH_ASSET = 57; | ||
| export const OP_DIAL_TLS = 58; | ||
| export const OP_HOSTNAME = 59; | ||
| export let OP_READ: number; |
There was a problem hiding this comment.
This solution works for now - but we need to figure out how to do it elegantly. Fundamentally we need to keep in mind that op id cannot be retrieved until runtime (especially not during snapshotting).
Ref #3025
| const ops = core.ops(); | ||
| // TODO(bartlomieju): this is a prototype, we should come up with | ||
| // something a bit more sophisticated | ||
| for (const [name, opId] of Object.entries(ops)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3002