Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(unstable): otel configuration #27333

Merged
merged 2 commits into from
Dec 12, 2024
Merged

refactor(unstable): otel configuration #27333

merged 2 commits into from
Dec 12, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Dec 11, 2024

split up otel config into user configurable and runtime configurable parts. user configurable part is now set via env vars parsed according to the otel spec. otel is now enabled via OTEL_DENO=true, and --unstable-otel only acts as a guard.

Fixes: #27273

@devsnek devsnek merged commit 5f8be05 into main Dec 12, 2024
17 checks passed
@devsnek devsnek deleted the x/otel-config branch December 12, 2024 08:17
dsherret pushed a commit that referenced this pull request Jan 9, 2025
split up otel config into user configurable and runtime configurable
parts. user configurable part is now set via env vars parsed according
to the otel spec. otel is now enabled via `OTEL_DENO=true`, and
`--unstable-otel` only acts as a guard.

Fixes: #27273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otel: "unstable": ["otel"] in deno.json seems not to enable sending of signals
2 participants