Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile): correct buffered reading of assets and files #27008

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix(compile): correct buffered reading of assets and files #27008

merged 3 commits into from
Nov 22, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Nov 22, 2024 •
edited
Loading

Closes #27006

@dsherret dsherret changed the title fix(compile): buffered reading of assets was broken fix(compile): buffered reading of assets and files was broken Nov 22, 2024
@dsherret dsherret changed the title fix(compile): buffered reading of assets and files was broken fix(compile): correct buffered reading of assets and files Nov 22, 2024
@dsherret dsherret requested a review from bartlomieju November 22, 2024 18:48
@dsherret dsherret marked this pull request as ready for review November 22, 2024 18:48
@dsherret dsherret requested a review from nathanwhit November 22, 2024 18:49
nathanwhit
nathanwhit approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member

Any chance you could try if it fixes #27001 too?

@dsherret dsherret enabled auto-merge (squash) November 22, 2024 19:24
@dsherret
Copy link
Member Author

Probably

@dsherret dsherret merged commit 4ded751 into denoland:main Nov 22, 2024
17 checks passed
@dsherret dsherret deleted the fix_buffered_reading_vfs_deno_compile branch November 22, 2024 20:00
@dsherret
Copy link
Member Author

dsherret commented Nov 22, 2024 •
edited
Loading

No, it doesn't fix it. Looking into that now.

Edit: I must have been doing something wrong because it's working now.

@dsherret dsherret mentioned this pull request Nov 22, 2024
Closed
bartlomieju pushed a commit that referenced this pull request Nov 28, 2024
@dsherret @bartlomieju
fix(compile): correct buffered reading of assets and files (#27008)
7a54251 
Closes #27006
@chibat chibat mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@std/http/file-server does not support --include in compile
3 participants
@dsherret @bartlomieju @nathanwhit