Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): don't use self-closing tags in HTML #26754

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(fmt): don't use self-closing tags in HTML #26754

merged 1 commit into from
Nov 6, 2024
+2 −2

Conversation

bartlomieju
Copy link
Member

Closes #26748

nathanwhit
nathanwhit approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 64e8870 into denoland:main Nov 6, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fmt_self_closing branch November 6, 2024 12:56
littledivy pushed a commit that referenced this pull request Nov 10, 2024
@bartlomieju @littledivy
fix(fmt): don't use self-closing tags in HTML (#26754)
6b74935 
Closes #26748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML formatter converts void elements to self closing tags
2 participants
@bartlomieju @nathanwhit