feat(ext/node): Promisify fstat and implement FileHandle#stat
#26719
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzt
force-pushed
the
manzt/fstat-promise
branch
5 times, most recently
from
bd5b907
to
bc98058
Compare
manzt
commented
Nov 4, 2024
| @@ -152,7 +161,7 @@ function fsCall(fn, handle, ...args) { | |||
| }); | |||
| } | |||
|
|
|||
| return fn(handle, ...args); | |||
| return fn(handle.fd, ...args); | |||
There was a problem hiding this comment.
Added a test as well for fh.writeFile() to make sure this change is OK.
There was a problem hiding this comment.
I think we should rather let fstat accept FileHandle, which improves the compatibility further (See this change for reference #25555 )
This fsCall util comes from this part in Node.js ( https://github.com/nodejs/node/blob/ccac4ee19d508abaf38bbabb87288ddeec7fcc21/lib/internal/fs/promises.js#L452-L470 ). I think it would be better to keep the code as aligned to node.js as possible.
manzt
force-pushed
the
manzt/fstat-promise
branch
from
e3b22c0
to
e369177
Compare
manzt
force-pushed
the
manzt/fstat-promise
branch
from
e369177
to
a70a10c
Compare
manzt
changed the title
fstat and implement FileHandle#stat
|
Oops, seeing #24391. Feel free to close. Although, I don't think that PR handles checking the whether the file is open prior to executing the fs operations. Probably should use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23301
Implements
FileHandle.stat. This PR also adds a promisifiedfs.fstatunder 'fs/promises', which is used internally byFileHandle.stat.