Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): scope attribution for lazily loaded assets #26699

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix(lsp): scope attribution for lazily loaded assets #26699

merged 2 commits into from
Nov 4, 2024
+50 −6

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #25999. Asset documents at

deno/cli/tsc/mod.rs

Lines 162 to 164 in 2c8a0e7

pub static LAZILY_LOADED_STATIC_ASSETS: Lazy<
HashMap<&'static str, &'static str>,
> = Lazy::new(|| {
were not being loaded properly.

@nayeemrmn nayeemrmn enabled auto-merge (squash) November 3, 2024 09:47
nathanwhit
nathanwhit approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsherret
dsherret approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit d67765b into denoland:main Nov 4, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-lazy-loaded-assets branch November 4, 2024 20:02
bartlomieju pushed a commit that referenced this pull request Nov 5, 2024
@nayeemrmn @bartlomieju
fix(lsp): scope attribution for lazily loaded assets (#26699)
7fc74b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opening lib.deno.url.d.ts causes frequent LSP errors
3 participants
@nayeemrmn @dsherret @nathanwhit