Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): missing import permission on PermissionOptionsObject #26627

Merged
merged 4 commits into from
Nov 4, 2024
Merged

fix(types): missing import permission on PermissionOptionsObject #26627

merged 4 commits into from
Nov 4, 2024

Conversation

stwiname
Copy link
Contributor

#26101 added support for specifying the import permission on web workers but the types were not updated to match the change.

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dsherret
dsherret approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret enabled auto-merge (squash) November 4, 2024 17:37
@dsherret dsherret merged commit d55e30f into denoland:main Nov 4, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Nov 5, 2024
@stwiname @bartlomieju
fix(types): missing import permission on PermissionOptionsObject (#…
f6a0ba7 
…26627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stwiname @CLAassistant @dsherret