Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support watch flag to enable watching other files than the main module on serve subcommand #26622

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: support watch flag to enable watching other files than the main module on serve subcommand #26622

merged 2 commits into from
Oct 29, 2024

Conversation

HasanAlrimawi
Copy link
Contributor

closes #26618

Changes

  • Supported watch flag in order to take files and dirs specified when pairing it with serve subcommand.
  • Added a test to practice the change.

bartlomieju
bartlomieju approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit 3b28446 into denoland:main Oct 29, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Oct 29, 2024
@HasanAlrimawi @bartlomieju
fix: support watch flag to enable watching other files than the main …
1019184 
…module on serve subcommand (#26622)

Closes #26618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno serve --watch=some_file.ts doesn't watch the specified file
2 participants
@HasanAlrimawi @bartlomieju