-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workspace): support wildcard packages #26568
Conversation
This probably doesn't solve the linked issue.
It appears the current change doesn't cover a mixes deno/npm members. @dsherret could you advise? |
Can you add a failing test to this pr to demonstrate what you mean? |
Or actually, adding one to deno_config would be better. |
@dsherret sure, opened a PR with a test here: denoland/deno_config#132 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
To save on CI time you may want to consider deleting the test in favour of the one in deno_config (maybe)
I prefer to have end-to-end test for execution. |
This commit adds support for wildcard packages in `workspace` configuration option in `deno.json`. This is now supported: ``` { "workspace": [ "./packages/*" ] } ``` Closes #25783
This commit adds support for wildcard packages in
workspace
configuration option in
deno.json
. This is now supported:Closes #25783