Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Fixed missing subcommands and typo in deno --help #26321

Merged

Conversation

ckrassow
Copy link
Contributor

@ckrassow ckrassow commented Oct 16, 2024

Added completions, lsp and types to the list of subcommands in the deno --help command. Also fixed small typo.
Issue: #26096

@crowlKats
Copy link
Member

The missing subcommands was an intentional choice, since those commands are either extremely rare use that dont need to be on the output but can be found on the website, or in the case of the lsp command, should basically not called manually

@ckrassow
Copy link
Contributor Author

The missing subcommands was an intentional choice, since those commands are either extremely rare use that dont need to be on the output but can be found on the website, or in the case of the lsp command, should basically not called manually

Okay makes sense! I'll remove the missing subcommands and only keep the spelling mistake.

@matthewjnield
Copy link

matthewjnield commented Nov 11, 2024

Since the subcommands were intentionally left out from the CLI help menu, I am closing #26096.

Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@crowlKats crowlKats merged commit 3f3568b into denoland:main Nov 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants