Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(add): exact version should not have range ^ specifier #26302

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix(add): exact version should not have range ^ specifier #26302

merged 4 commits into from
Oct 16, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Fixes #26299

@marvinhagemeister
Copy link
Contributor Author

marvinhagemeister commented Oct 16, 2024 •
edited
Loading

oh wait it looks like the same issue also exists with JSR specifiers. Marking as draft again.

EDIT: ready now.

@marvinhagemeister marvinhagemeister marked this pull request as draft October 16, 2024 11:59
@marvinhagemeister marvinhagemeister marked this pull request as ready for review October 16, 2024 12:05
@marvinhagemeister
Copy link
Contributor Author

Hm looks like checking the VersionReq afterwards is not the right move, as they will also be the same when you specify no version and there is only one version that matches.

dsherret
dsherret approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dsherret
dsherret reviewed Oct 16, 2024
View reviewed changes
cli/tools/registry/pm.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinhagemeister marvinhagemeister merged commit e515f3d into main Oct 16, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the fix_exact_version_install branch October 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno add -D npm:[email protected] always installs the latest alpha version
2 participants
@marvinhagemeister @dsherret