Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(add): create deno.json when running deno add jsr:<pkg> #26275

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix(add): create deno.json when running deno add jsr:<pkg> #26275

merged 2 commits into from
Oct 15, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Oct 15, 2024 •
edited
Loading

Fixes #26119.

Originally I wanted to put them in package.json if there's no deno.json, but on second thought it makes more sense to just create a deno.json

bartlomieju
bartlomieju approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nathanwhit nathanwhit enabled auto-merge (squash) October 15, 2024 16:09
@nathanwhit nathanwhit merged commit 797405f into main Oct 15, 2024
17 checks passed
@nathanwhit nathanwhit deleted the add-jsr-deno-json branch October 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno add fails to add a jsr: package to a deno.json when project only contains package.json
2 participants
@nathanwhit @bartlomieju