-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add hint for missing document
global in terminal error
#26218
fix: add hint for missing document
global in terminal error
#26218
Conversation
DO NOT LAND. It's not great if
It should be enhancing terminal errors in |
It will also grate to add this in the documentation related to testing, the need to add a library like |
Moves code for generating suggestions and hint to `cli/fmt_errors.rs`. This effectively applies suggestion to any place that format JS errors in terminal, like `deno test`. Addresses #26218 (comment)
document
global in terminal errordocument
global in terminal error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: David Sherret <[email protected]> Signed-off-by: Bartek Iwańczuk <[email protected]>
This came up on Discord as a question so I thought it's worth adding a hint for this
as it might be a common pitfall.