New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): allow writing to tty columns #26201

Merged

littledivy merged 2 commits into denoland:main from littledivy:stdio_columns_writable

Oct 14, 2024

Member

littledivy commented Oct 13, 2024 •

edited

Loading

Behave similar to Node.js where modifying stdout.columns doesn't really resize the terminal. Ref nodejs/node#17529

Fixes #26196


          fix(ext/node): allow writing to tty columns

a68fad4

Member

bartlomieju commented Oct 13, 2024

Can we test it somehow?


          Add test

35bba82

littledivy requested a review from bartlomieju

October 14, 2024 06:42

bartlomieju approved these changes

View reviewed changes

littledivy merged commit 68b388a into denoland:main

17 checks passed

littledivy deleted the stdio_columns_writable branch

October 14, 2024 08:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet