fix: share inotify fd across watchers #26200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Oct 21, 2024
Comment on lines
+136
to
+139
| event.paths.iter().any(|event_path| { | ||
| same_file::is_same_file(event_path, path).unwrap_or(false) | ||
| || starts_with_canonicalized(event_path, path) | ||
| }) |
There was a problem hiding this comment.
Can we be smarter here? Iterating over all paths specified for each watcher can be costly. Maybe a hash set would work better here to try and match file path directly?
There was a problem hiding this comment.
Two watchers can be watching the same file/directory so HashSet won't work.
That would work but won't be fast for most cases that require high file watchers (recursive) because we need to fallback when paths are inside directory or symlinked.
bartlomieju
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26104
Fixes #26071
Fixes #17757