fix: cjs resolution cases #25739
Merged
fix: cjs resolution cases #25739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Sep 20, 2024
Comment on lines
+129
to
+131
| // FIXME: `deno_ast` should internally handle MediaType::Cjs implying that | ||
| // the result must never be Esm | ||
| Ok(CliCjsAnalysis::Cjs { |
There was a problem hiding this comment.
Could you open an issue in deno_ast before landing?
bartlomieju
approved these changes
Sep 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cjs modules being loaded as esm.